Add Object.assign polyfill support #210
Conversation
|
@armills, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @robbiet480 and @syphernl to be potential reviewers. |
| "ru_demo": "rollup --config rollup/demo.js", | ||
| "watch_ru_all": "npm run watch_ru_core && npm run watch_ru_demo", | ||
| "watch_ru_all": "(npm run watch_ru_core & npm run watch_ru_compatibility & npm run watch_ru_demo) && wait", |
There was a problem hiding this comment.
These were being run in sequence previously, which ends up only watching core. I believe the intention is to watch all of them at once.
There was a problem hiding this comment.
interesting, I never realized that. Then again, we hardly develop anything but the core.
There was a problem hiding this comment.
That's what I figured. Just wanted to confirm.
src/compatibility.js
Outdated
| @@ -0,0 +1,2 @@ | |||
| require('es6-object-assign').polyfill(); | |||
There was a problem hiding this comment.
You can make this ES6.
import objAssign from es6-object-assign;
objAssign.polyfill();There was a problem hiding this comment.
Ah, this is what I was missing.
src/compatibility.js
Outdated
| @@ -0,0 +1,2 @@ | |||
| require('es6-object-assign').polyfill(); | |||
| module.exports = Object; | |||
rollup/compatibility.js
Outdated
| moduleName: 'compatibility', | ||
| }, | ||
| ], | ||
| exports: 'default', |
There was a problem hiding this comment.
No need to expose an export as this is a polyfill.
emlove
force-pushed
the
object-assign-polyfill
branch
from
a0f523a to
d4a2cd4
Compare
Change from using either MarkDown quotes or custom CSS tool tips to the new native boxes in DSv2 which are much punchier and fresher looking.
This PR adds a new js module compatibility.js, which currently adds polyfill support for Object.assign.