Ask "save login" after hass connected #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
awarecan
changed the title
balloob
approved these changes
Sep 3, 2018
|
Damn pesky race conditions, great find! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
askWrite() should be called only hassConnection established, e.g., authentication passed.
Fixes: home-assistant/core#16347
Lots of users report that they never seen "save login" dialog. I finally can reproduce this issue by using Firefox (showdom==False) access my production box through external network. After some investigation, I found out that sometime
askWrite()will be called before HAWS calledsaveTokens(), thereforeaskWrite()will return false, the "save login" dialog didn't show up.Move
askWrite() intohassConnectedfromreadyshould resolve it.