Autocapitalization of username field #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
timmo001
changed the title
jeradM
reviewed
Sep 2, 2018
src/onboarding/ha-onboarding.js
Outdated
| @@ -42,6 +42,7 @@ class HaOnboarding extends localizeLiteMixin(PolymerElement) { | |||
| value='{{_name}}' | |||
| required | |||
| auto-validate | |||
| autocapitalize='words' | |||
There was a problem hiding this comment.
I think we should use on/sentences here instead. There is an ongoing issue since iOS 8 with words that causes the first 2 letters to be capitalized instead of every word (I've confirmed this is still an issue in 11.4). That is much more annoying IMO than having to manually capitalize extra words
There was a problem hiding this comment.
Really..? Since the names I use are one word anyway I'm OK with this
balloob
approved these changes
Sep 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets
autocapitalizefor username and name fields. This makes sure the username is always lowercase when logging in or creating accounts with mobile devices.Related issue this fixes
#1626