Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make valid attributes a table instead of raw JSON #149

Merged
merged 3 commits into from
Nov 27, 2016

Conversation

robbiet480
Copy link
Member

No description provided.

@mention-bot
Copy link

@robbiet480, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob and @justweb1 to be potential reviewers.

@balloob
Copy link
Member

balloob commented Oct 31, 2016

You'll want to remove the margin of the pre used for parameter name.
screen shot 2016-10-30 at 21 32 19

Show a message when no description is available. Differentiate between services known to HA and ones that are not known (known services can still have no description).
screen shot 2016-10-30 at 21 33 07

Show a message that the user has to pick a service/domain when none selected.
screen shot 2016-10-30 at 21 34 29

Soo, in the future maybe we should allow people to fill in values directly next to the description 👍

@balloob balloob self-assigned this Oct 31, 2016
@robbiet480
Copy link
Member Author

@balloob should be good to go

@balloob
Copy link
Member

balloob commented Nov 2, 2016

One final change: when selecting a new domain, can we auto select the first available service? (means we can also get rid of no service selected)

@balloob
Copy link
Member

balloob commented Nov 2, 2016

Ok to merge when comment addressed 🐬

@robbiet480
Copy link
Member Author

will most likely do that change tomorrow as well as adding the right side list back thx

@balloob balloob merged commit c22586d into master Nov 27, 2016
@balloob balloob deleted the attributes-in-table branch November 27, 2016 22:02
tkdrob pushed a commit to tkdrob/frontend that referenced this pull request Apr 20, 2021
Add missing "title" to android notification example
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants