Filter external attributes #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will not scale. I wonder if we should move to a generic format. Like custom_name_homebridge and custom_hidden_homebridge, then just filter out anything that starts with custom_ This should obviously be part of a greater workflow discussion on how we want to handle all these integrations. For know this pr is fine as this are the attributes that people expect. |
robbiet480
added a commit
that referenced
this pull request
Sep 3, 2016
* Filter out emulated_hue keys * Filter out Haaska keys * Filter out homebridge-homeassistant keys * Fix linting issues
tkdrob
pushed a commit
to tkdrob/frontend
that referenced
this pull request
Apr 20, 2021
…ningUpdate Update beta cleaning steps
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull adds the following keys to the default more info
FILTER_KEYS:I did this because @arsaboo pointed out that the card looks a bit squished with these attributes, and they don't provide any value to the frontend.
Here's the screenshot that convinced me
I made this a PR instead of pushing direct to master because I am unsure if we want to make this a precedent, especially for a totally external tool (Haaska). @balloob, can I get your thoughts?