-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline setting up dev env #588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only thing not covered I’ve run into is that if you run script/setup
in WSL and then try and commit via Windows you may need to setup pre-commit again in Windows. I think that’s a topic for elsewhere though.
|
||
```shell | ||
$ hass | ||
hass -c config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, we should make the config loading/search of HA look for a local config
folder first, next the other options currently already there.
If none exists and config is created, skip the local config
folder as a possible option to create the config files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would be too much of a breaking change right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments, but in general: 🎉
Co-authored-by: Franck Nijhof <git@frenck.dev>
Proposed change
Streamlines setting up a dev env.
$
from shell command blocks containing a single commandvenv
instructions as it will be part ofscript/setup
logging
config as it will be part ofscript/setup
Requires core PR: home-assistant/core#37075
Type of change
Additional information