-
-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lawn-mower.md with returning state #2280
Update lawn-mower.md with returning state #2280
Conversation
WalkthroughWalkthroughThe recent update introduces a new state, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant LawnMower
participant Dock
User->>LawnMower: Start mowing
LawnMower->>LawnMower: Change state to MOWING
LawnMower->>User: Mowing in progress
LawnMower->>LawnMower: Finish mowing
LawnMower->>LawnMower: Change state to RETURNING
LawnMower->>Dock: Move to docking station
Dock->>LawnMower: Docked
LawnMower->>LawnMower: Change state to DOCKED
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
docs/core/entity/lawn-mower.md (1)
26-26
: Consider adding the article "the".In the description for the
RETURNING
state, consider adding the article "the" for grammatical correctness.- | `RETURNING` | The lawn mower is returning to dock. + | `RETURNING` | The lawn mower is returning to the dock.Tools
LanguageTool
[uncategorized] ~26-~26: You might be missing the article “the” here.
Context: ...RNING| The lawn mower is returning to dock. |
ERROR` | The lawn mower encountere...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
This PR should include a blog post explaining the new activity |
Done. |
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
@@ -0,0 +1,30 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the filename to todays date and then I think it's good to go 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to 08-23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
blog/2024-08-23-lawn-mower-activity-returning.md (1)
4-4
: Remove quotes from the title.The title should not use quotes for UI strings. Use bold instead if needed.
-title: "New returning type in LawnMowerActivity" +title: New returning type in LawnMowerActivity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mikey0000 👍
Update lawn mower state with returning
core: home-assistant/core#124261
architecture: home-assistant/architecture#1123
frontend: home-assistant/frontend#21740
Proposed change
Type of change
Additional information
Summary by CodeRabbit
Summary by CodeRabbit
RETURNING
, for the lawn mower, providing enhanced feedback on its activity as it returns to the docking station.RETURNING
state and its implementation within the Home Assistant ecosystem, improving clarity on managing the lawn mower's operational statuses.