-
-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document integration can consume the state of entities which provide location #2081
Document integration can consume the state of entities which provide location #2081
Conversation
@@ -23,6 +23,8 @@ To suggest a new domain, start a discussion in [the architecture repository](htt | |||
|
|||
These integrations interact with external devices & services and make them available in Home Assistant via integrations that define IoT domains like `light`. An example of such an integration is Philips Hue. Philips Hue lights are made available as light entities in Home Assistant. | |||
|
|||
Integrations which interact with external devices & services are generally not allowed to consume the state of entities from other integrations, with the exception of entities from other integrations which have a location, e.g. the state of zone and device_tracker entities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not exclude sensor entities with lat
and long
set in the state attributes, as they also show on the map. iss
is an example for this.
When you read this, you could read such entity as "entities from other integrations which have a location"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to assume our developers read the documentation like the devil reads the bible? A sensor, or button, or switch, is not designed to provide a location whereas a device tracker or zone entity is.
Having said that, do you have a suggestion for how to make it clearer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True true, just sharing this in case you weren't aware. I don't have any other proposals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your concern is valid, it's just that I also don't have a great idea for how to make it clearer :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've said that we allow location state from other integrations. It doesn't matter what kind of entity that is. If something seems weird in a PR, we'll take it up for discussion at that time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed change
Document integration can consume the state of entities which provide location
Type of change
Additional information