Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct unit of rain pause #98131

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Correct unit of rain pause #98131

merged 1 commit into from
Aug 10, 2023

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Aug 9, 2023

Proposed change

Adjust rain pause entity to be in minutes as that is what the device expect.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 10, 2023 10:17
@frenck frenck removed this from the 2023.8.2 milestone Aug 10, 2023
@elupus elupus marked this pull request as ready for review August 10, 2023 10:21
@home-assistant home-assistant bot requested a review from frenck August 10, 2023 10:21
@frenck frenck added this to the 2023.8.2 milestone Aug 10, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @elupus 👍

../Frenck

@frenck frenck merged commit 9b74321 into home-assistant:dev Aug 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
@elupus elupus deleted the gardena/pause branch August 18, 2023 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants