Tweak visibility config #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ATTR_HIDDEN not in attr: | ||
| attr[ATTR_HIDDEN] = bool(self.hidden) | ||
| if _OVERWRITE_HIDDEN.get(self.entity_id, self.hidden): | ||
| attr[ATTR_HIDDEN] = True |
There was a problem hiding this comment.
This is clever because it will prevent the "hidden: False" message from showing up in all the state cards for sensors and switches on the frontend. I like it.
|
I agree on all counts. As long as all entities inherit the Entity class, VisibiltyABC needs not to exist. The CONTRIBUTING.md file would need to be updated to reflect this, however. I put a note in there about the VisibilityABC class. Looks like the link I put in the visibility section is also a little messed up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After migrating group to use entity I was looking at the VisibilityABC class. In my opinion it fits better integrated into Entity instead of being a standalone class. Also figured that comparing to a string 'hide' should be part of the config parsing (bootstrap module) and not in the helper.
This pull request fixes both. Added some tests to make sure I didn't break anything.