Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yeelight to v0.7.13 #97933

Merged
merged 2 commits into from
Aug 6, 2023
Merged

Conversation

alexyao2015
Copy link
Contributor

Proposed change

changelog: https://gitlab.com/stavros/python-yeelight/-/compare/v0.7.12...v0.7.13

Fixes race condition when enabling music mode

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Aug 6, 2023

Hey there @zewelor, @shenxn, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (yeelight) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of yeelight can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign yeelight Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@alexyao2015
Copy link
Contributor Author

Marking as draft until required gitlab yeelight MR is merged.

@alexyao2015 alexyao2015 marked this pull request as draft August 6, 2023 20:31
@joostlek
Copy link
Member

joostlek commented Aug 6, 2023

image

@joostlek
Copy link
Member

joostlek commented Aug 6, 2023

Ah never mind

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the incoming change. Good to go once release is made

@bdraco bdraco added this to the 2023.8.2 milestone Aug 6, 2023
@alexyao2015 alexyao2015 marked this pull request as ready for review August 6, 2023 21:31
@bdraco
Copy link
Member

bdraco commented Aug 6, 2023

Thanks @alexyao2015

@bdraco bdraco merged commit df8f132 into home-assistant:dev Aug 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
@alexyao2015 alexyao2015 deleted the upgrade-yeelight branch August 10, 2023 19:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YeeLight Unavailable
5 participants