Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling HomeKit events when the char is in error state #97884

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 6, 2023

Proposed change

Fixes the below which was introduced in #97869 by moving the check deeper down so it shouldn't get there if the char has an error status

I didn't see this when testing the original PR because I didn't have any chars returning -70402

2023-08-05 18:37:50.146 DEBUG (MainThread) [homeassistant.components.homekit_controller.device_trigger] Event (11158856,67) {'status': -70402, 'description': 'Unable to communicate with requested service, e.g. the power to the accessory was turned off.'}
2023-08-05 18:37:50.146 ERROR (MainThread) [homeassistant.components.homekit_controller.connection] Unexpected exception from <bound method HKDevice.async_update of <homeassistant.components.homekit_controller.connection.HKDevice object at 0x7fb3787fa690>>
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/debounce.py", line 116, in _handle_timer_finish
    await task
  File "/usr/src/homeassistant/homeassistant/components/homekit_controller/connection.py", line 786, in async_update
    self.process_new_events(new_values_dict)
  File "/usr/src/homeassistant/homeassistant/components/homekit_controller/connection.py", line 797, in process_new_events
    async_fire_triggers(self, new_values_dict)
  File "/usr/src/homeassistant/homeassistant/components/homekit_controller/device_trigger.py", line 271, in async_fire_triggers
    if ev["value"] is None:
       ~~^^^^^^^^^
KeyError: 'value'

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Fixes the below which was introduced in #97869
```
2023-08-05 18:37:50.146 DEBUG (MainThread) [homeassistant.components.homekit_controller.device_trigger] Event (11158856,67) {'status': -70402, 'description': 'Unable to communicate with requested service, e.g. the power to the accessory was turned off.'}
2023-08-05 18:37:50.146 ERROR (MainThread) [homeassistant.components.homekit_controller.connection] Unexpected exception from <bound method HKDevice.async_update of <homeassistant.components.homekit_controller.connection.HKDevice object at 0x7fb3787fa690>>
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/debounce.py", line 116, in _handle_timer_finish
    await task
  File "/usr/src/homeassistant/homeassistant/components/homekit_controller/connection.py", line 786, in async_update
    self.process_new_events(new_values_dict)
  File "/usr/src/homeassistant/homeassistant/components/homekit_controller/connection.py", line 797, in process_new_events
    async_fire_triggers(self, new_values_dict)
  File "/usr/src/homeassistant/homeassistant/components/homekit_controller/device_trigger.py", line 271, in async_fire_triggers
    if ev["value"] is None:
       ~~^^^^^^^^^
KeyError: 'value'
```
@home-assistant
Copy link

home-assistant bot commented Aug 6, 2023

Hey there @Jc2k, mind taking a look at this pull request as it has been labeled with an integration (homekit_controller) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homekit_controller can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homekit_controller Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco added this to the 2023.8.2 milestone Aug 6, 2023
@bdraco
Copy link
Member Author

bdraco commented Aug 6, 2023

pushed to the system with the device that has the unavailable char. all good now

@bdraco bdraco merged commit 91b308b into dev Aug 6, 2023
@bdraco bdraco deleted the follow_fix_97869 branch August 6, 2023 05:14
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants