Bump zeroconf to 0.74.0 #97745
Merged
Bump zeroconf to 0.74.0 #97745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: python-zeroconf/python-zeroconf@0.72.3...0.74.0 - more cython build fixes - performance improvements (mostly for pyatv)
home-assistant
bot
added
cla-signed
core
dependency
integration: zeroconf
small-pr
bdraco
commented
Aug 4, 2023
| ext_pan_id = service.properties.get(b"xp") | ||
| network_name = try_decode(service.properties.get(b"nn")) | ||
| model_name = try_decode(service.properties.get(b"mn")) | ||
| service_properties = service.properties |
There was a problem hiding this comment.
This was typed to dict before in upstream zeroconf so mypy never errored before. This design was inherited from many many years ago and changing it would be breaking. The lack of typing was hiding the issue.
bdraco
commented
Aug 4, 2023
Comment on lines
557
to
562
| service_properties = service.properties | ||
| if TYPE_CHECKING: | ||
| # Service properties are always bytes if they are set from the network. | ||
| # For legacy backwards compatibility zeroconf allows properties to be set | ||
| # as strings but we never do that so we can safely cast here. | ||
| service_properties = cast(dict[bytes, bytes | None], service_properties) |
There was a problem hiding this comment.
This was typed to dict before in upstream zeroconf so mypy never errored before. This design was inherited from many many years ago and changing it would be breaking. The lack of typing was hiding the issue.
balloob
approved these changes
Aug 4, 2023
frenck
pushed a commit
that referenced
this pull request
Aug 4, 2023
* Bump zeroconf to 0.74.0 changelog: python-zeroconf/python-zeroconf@0.72.3...0.74.0 - more cython build fixes - performance improvements (mostly for pyatv) * handle typing * handle typing * remove if TYPE_CHECKING, this doesnt get called that often * remove if TYPE_CHECKING, this doesnt get called that often
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
changelog: python-zeroconf/python-zeroconf@0.72.3...0.74.0
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: