Ensure trigger sentences do not contain punctuation #95633
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This PR adds validation to the sentence trigger to ensure that punctuation is not present. A soft warning in the frontend is also being worked on: home-assistant/frontend#17119
Every character in a sentence template must match unless it's marked optional. hassil automatically strips punctuation from the input text during matching, so the templates should not require it.
Note that this can lead to some non-intuitive templates: for example, matching the phrases "It's 4 a.m." or "It's 4am". Whisper returns the text "It's 4:00 AM." for the spoken phrase, but the colon is considered punctuation! Periods are also punctuation (even in abbreviations), so the template
it's 4[00][ ]am
is needed to cover all of the cases.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: