-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mypermobil integration #95613
Add Mypermobil integration #95613
Conversation
Hi @IsakNyberg It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments to get the review process going. I haven't looked at the config flow and tests yet. I think that at this point, there is a bit of work to be done on the sensors and integration setup first.
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
In order to keep this PR simple i have removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @IsakNyberg 👍
Thank you! :) |
Breaking change
Proposed change
Add the integration for Permobil electric wheelchairs. The integration includes various sensors with information about the wheelchair, such as battery status, distance traveled, number of seating adjustments, etc.
Library: https://pypi.org/project/mypermobil/
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: