Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mypermobil integration #95613

Merged
merged 54 commits into from
Nov 24, 2023
Merged

Add Mypermobil integration #95613

merged 54 commits into from
Nov 24, 2023

Conversation

IsakNyberg
Copy link
Contributor

@IsakNyberg IsakNyberg commented Jun 30, 2023

Breaking change

Proposed change

Add the integration for Permobil electric wheelchairs. The integration includes various sensors with information about the wheelchair, such as battery status, distance traveled, number of seating adjustments, etc.

Library: https://pypi.org/project/mypermobil/

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hi @IsakNyberg

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@GrishaVar
Copy link

Looks good!

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments to get the review process going. I haven't looked at the config flow and tests yet. I think that at this point, there is a bit of work to be done on the sensors and integration setup first.

../Frenck

homeassistant/components/permobil/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/permobil/manifest.json Outdated Show resolved Hide resolved
homeassistant/components/permobil/manifest.json Outdated Show resolved Hide resolved
homeassistant/components/permobil/manifest.json Outdated Show resolved Hide resolved
homeassistant/components/permobil/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/permobil/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/permobil/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/permobil/strings.json Outdated Show resolved Hide resolved
homeassistant/components/permobil/strings.json Outdated Show resolved Hide resolved
homeassistant/components/permobil/strings.json Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft July 25, 2023 08:38
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@IsakNyberg IsakNyberg marked this pull request as ready for review July 26, 2023 07:49
@home-assistant home-assistant bot requested a review from frenck July 26, 2023 07:49
@IsakNyberg
Copy link
Contributor Author

In order to keep this PR simple i have removed the Is Charging sensor and the Record Distance Sensor since they both require extra logic. I will add them in a separate PR.

@IsakNyberg IsakNyberg marked this pull request as ready for review October 31, 2023 08:38
homeassistant/components/permobil/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/permobil/sensor.py Outdated Show resolved Hide resolved
tests/components/permobil/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/permobil/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/permobil/test_config_flow.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft October 31, 2023 09:29
@IsakNyberg IsakNyberg marked this pull request as ready for review October 31, 2023 19:31
@home-assistant home-assistant bot marked this pull request as draft November 6, 2023 09:26
@IsakNyberg IsakNyberg marked this pull request as ready for review November 6, 2023 19:07
tests/components/permobil/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/permobil/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/permobil/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/permobil/test_config_flow.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 14, 2023 13:50
@IsakNyberg IsakNyberg marked this pull request as ready for review November 22, 2023 09:02
@edenhaus edenhaus self-assigned this Nov 24, 2023
@edenhaus edenhaus dismissed stale reviews from gjohansson-ST and frenck November 24, 2023 09:13

Stale

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IsakNyberg 👍

@edenhaus edenhaus merged commit e03ccb5 into home-assistant:dev Nov 24, 2023
47 of 49 checks passed
@IsakNyberg
Copy link
Contributor Author

Thank you! :)

@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants