-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pyopnsense to support a 20 second timeout #95314
Conversation
Hey there @mtreinish, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
What is driving this change? |
#81815 has the full investigation but basically fetching the arp table from the opnsense router takes longer than the default timeout of 5 seconds. This has already been fixed in opnsense in the past opnsense/core#4666 . However the response time scales with the number of clients so we're still hitting the 5s timeout. |
Breaking change
Proposed change
This changes the OPNSense timeout from 5 to 20 seconds. To do this I also updated pyopnsense from 0.2.0 to 0.4.0:
Type of change
Additional information
This PR is related to issue:Checklist
black --fast homeassistant tests
)Tests have been added to verify that the new code works.If user exposed functionality or configuration variables are added/changed:
Documentation added/updated for www.home-assistant.ioIf the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: