Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple smart detects firing at once for UniFi Protect #94133

Merged
merged 4 commits into from
Jun 7, 2023
Merged

Fix multiple smart detects firing at once for UniFi Protect #94133

merged 4 commits into from
Jun 7, 2023

Conversation

AngellusMortis
Copy link
Contributor

Proposed change

Changelog: https://github.com/AngellusMortis/pyunifiprotect/releases/tag/v4.10.0

If multiple smart detect events came in at once with different detections, it could not detect them properly before. This changes things up to use the new attributes added in the new version of pyunifiprotect to only consider the last event for the a given smart detection for triggering the sensor instead of looking at is_smart_detected and the last overall smart detection.

Also adds more debug logging to troubleshoot smart detection issues.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jun 6, 2023

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (unifiprotect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of unifiprotect can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign unifiprotect Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco added this to the 2023.6.0 milestone Jun 6, 2023
@balloob balloob merged commit 9b6a914 into home-assistant:dev Jun 7, 2023
@AngellusMortis AngellusMortis deleted the fix-multi-event branch June 7, 2023 00:08
balloob pushed a commit that referenced this pull request Jun 7, 2023
* Fix multiple smart detects firing at once

* Tweak

* Clean up logging. Linting

* Linting
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants