Add Ezviz number entity #93366
Add Ezviz number entity #93366
Conversation
|
Hey there @BaQs, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Please open a documentation PR adjusting https://www.home-assistant.io/integrations/ezviz/ and link it in this issue.
Also, please improve the breaking description change, it's what will be shown to our users in the release notes.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
| try: | ||
| return float(self.data[self._sensor_name]) | ||
| except ValueError: | ||
| return 0.0 |
There was a problem hiding this comment.
Shouldn't this return None at that point? The value = unknown.
| ) | ||
|
|
||
| except (HTTPError, PyEzvizError) as err: | ||
| raise PyEzvizError("Cannot set detection sensitivity level") from err |
There was a problem hiding this comment.
PyEzvizError is an error from an external library, which should not be raised from within Home Assistant. Please raise an HomeAssistantError instead.
|
According to feedback from @frenck, we don't need to add the breaking change section if use of a deprecated feature is detected and a repairs issue is raised. I removed it from the PR description accordingly. |
* Initial commit * Add number entity. * update coveragerc * Add services back and add depreciation repair. * Remove redundant typing declaration. * Case change in strings. * Apply cleanups from simular pull request. * Commit suggestions.
frenck
added
the
noteworthy
Proposed change
Replaces Ezviz "detection_sensibility" sensor with a new number entity called "Detection sensitivity".
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: