Fix lingering timer in esphome

[epenet]

Proposed change

Linked to #91360
https://github.com/home-assistant/core/actions/runs/4881750941/jobs/8711209278?pr=91360

ERROR tests/components/esphome/test_dashboard.py::test_new_info_reload_config_entries - Failed: Lingering timer after test <TimerHandle when=1254.230451539 Debouncer._on_debounce() created at /home/runner/work/core/core/homeassistant/helpers/debounce.py:152>
ERROR tests/components/esphome/test_dashboard.py::test_new_dashboard_fix_reauth - Failed: Lingering timer after test <TimerHandle when=1254.714376327 Debouncer._on_debounce() created at /home/runner/work/core/core/homeassistant/helpers/debounce.py:152>
ERROR tests/components/esphome/test_diagnostics.py::test_diagnostics - Failed: Lingering timer after test <TimerHandle when=1256.98213432 Debouncer._on_debounce() created at /home/runner/work/core/core/homeassistant/helpers/debounce.py:152>
ERROR tests/components/esphome/test_config_flow.py::test_reauth_fixed_via_dashboard - Failed: Lingering timer after test <TimerHandle when=1261.874176543 Debouncer._on_debounce() created at /home/runner/work/core/core/homeassistant/helpers/debounce.py:152>
ERROR tests/components/esphome/test_config_flow.py::test_reauth_fixed_via_dashboard_add_encryption_remove_password - Failed: Lingering timer after test <TimerHandle when=1262.34223002 Debouncer._on_debounce() created at /home/runner/work/core/core/homeassistant/helpers/debounce.py:152>
ERROR tests/components/esphome/test_config_flow.py::test_reauth_fixed_via_remove_password - Failed: Lingering timer after test <TimerHandle when=1262.733089128 Debouncer._on_debounce() created at /home/runner/work/core/core/homeassistant/helpers/debounce.py:152>
ERROR tests/components/esphome/test_config_flow.py::test_reauth_fixed_via_dashboard_at_confirm - Failed: Lingering timer after test <TimerHandle when=1263.250772384 Debouncer._on_debounce() created at /home/runner/work/core/core/homeassistant/helpers/debounce.py:152>
ERROR tests/components/esphome/test_update.py::test_update_entity[devices_payload0-on-expected_attributes0] - Failed: Lingering timer after test <TimerHandle when=1264.91458648 Debouncer._on_debounce() created at /home/runner/work/core/core/homeassistant/helpers/debounce.py:152>
ERROR tests/components/esphome/test_config_flow.py::test_discovery_hassio - Failed: Lingering timer after test <TimerHandle when=1265.230447055 Debouncer._on_debounce() created at /home/runner/work/core/core/homeassistant/helpers/debounce.py:152>
ERROR tests/components/esphome/test_update.py::test_update_entity[devices_payload1-off-expected_attributes1] - Failed: Lingering timer after job <Job DataUpdateCoordinator ESPHomeDashboard ESPHome Dashboard HassJobType.Coroutinefunction <bound method DataUpdateCoordinator._handle_refresh_interval of <homeassistant.components.esphome.dashboard.ESPHomeDashboard object at 0x7fdd476f1150>>>
ERROR tests/components/esphome/test_config_flow.py::test_zeroconf_encryption_key_via_dashboard - Failed: Lingering timer after test <TimerHandle when=1265.720199273 Debouncer._on_debounce() created at /home/runner/work/core/core/homeassistant/helpers/debounce.py:152>
ERROR tests/components/esphome/test_update.py::test_update_entity[devices_payload2-unavailable-expected_attributes2] - Failed: Lingering timer after job <Job DataUpdateCoordinator ESPHomeDashboard ESPHome Dashboard HassJobType.Coroutinefunction <bound method DataUpdateCoordinator._handle_refresh_interval of <homeassistant.components.esphome.dashboard.ESPHomeDashboard object at 0x7fdd3baf0d60>>>
ERROR tests/components/esphome/test_config_flow.py::test_zeroconf_no_encryption_key_via_dashboard - Failed: Lingering timer after test <TimerHandle when=1266.177248563 Debouncer._on_debounce() created at /home/runner/work/core/core/homeassistant/helpers/debounce.py:152>
ERROR tests/components/esphome/test_update.py::test_update_static_info - Failed: Lingering timer after job <Job DataUpdateCoordinator ESPHomeDashboard ESPHome Dashboard HassJobType.Coroutinefunction <bound method DataUpdateCoordinator._handle_refresh_interval of <homeassistant.components.esphome.dashboard.ESPHomeDashboard object at 0x7fdd47900340>>>
ERROR tests/components/esphome/test_update.py::test_update_device_state_for_availability - Failed: Lingering timer after job <Job DataUpdateCoordinator ESPHomeDashboard ESPHome Dashboard HassJobType.Coroutinefunction <bound method DataUpdateCoordinator._handle_refresh_interval of <homeassistant.components.esphome.dashboard.ESPHomeDashboard object at 0x7fdd44d001f0>>>
ERROR tests/components/esphome/test_update.py::test_update_entity_dashboard_not_available_startup - Failed: Lingering timer after job <Job DataUpdateCoordinator ESPHomeDashboard ESPHome Dashboard HassJobType.Coroutinefunction <bound method DataUpdateCoordinator._handle_refresh_interval of <homeassistant.components.esphome.dashboard.ESPHomeDashboard object at 0x7fdd44e3c130>>

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @OttoWinter, @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[epenet]

In draft until #92432 is resolved to avoid conflict
cc @bdraco

[epenet]

I am clearing the dashboard in case the new one fails on async_request_refresh.

Another option would be to only shutdown/clear the old one after the new succeeds but I think this is cleaner.

[epenet]

I also wonder if this should be included in a 2023.5.x patch release, if dashboards are recreated often.
cc @balloob

[frenck]

Dashboards are not recreated often, so not a really big deal.

[frenck]

Thanks, @epenet 👍

../Frenck