Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle webhook URL rejection in onvif #92405

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 3, 2023

Proposed change

fixes #92384

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented May 3, 2023

Hey there @hunterjm, mind taking a look at this pull request as it has been labeled with an integration (onvif) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of onvif can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign onvif Removes the current integration label and assignees on the pull request, add the integration domain after the command.

except ValidationError as err:
# This should only happen if there is a problem with the webhook URL
# that is causing it to not be well formed.
LOGGER.exception(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I logged the exception because we don't know why the URL is being rejected yet but falling back to pull point will happen in this case to keep things working while we wait for more information

@bdraco
Copy link
Member Author

bdraco commented May 3, 2023

retested to make sure webhooks still work with a few cameras

2023-05-03 08:42:09.966 DEBUG (MainThread) [homeassistant.components.onvif] tapo 200: Processed webhook onvif_0a1d5c3e0b6b424d8c7a772d0a1913d1 with 1 event(s)
2023-05-03 08:42:09.972 DEBUG (MainThread) [homeassistant.components.onvif] tapo 200: Processed webhook onvif_0a1d5c3e0b6b424d8c7a772d0a1913d1 with 1 event(s)
2023-05-03 08:42:09.976 DEBUG (MainThread) [homeassistant.components.onvif] tapo 200: Processed webhook onvif_0a1d5c3e0b6b424d8c7a772d0a1913d1 with 1 event(s)

@bdraco bdraco marked this pull request as ready for review May 3, 2023 13:42
@bdraco bdraco requested a review from hunterjm as a code owner May 3, 2023 13:42
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit 20942ab into dev May 3, 2023
@frenck frenck deleted the handle_webhook_url_rejection branch May 3, 2023 13:46
frenck pushed a commit that referenced this pull request May 3, 2023
dknowles2 pushed a commit to dknowles2/ha-core that referenced this pull request May 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing element Address (Subscribe.ConsumerReference.Address) when setting up onvif
3 participants