Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow numbers in TTS engine part of cache key #92031

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Conversation

synesthesiam
Copy link
Contributor

@synesthesiam synesthesiam commented Apr 25, 2023

TTS engine name is part of cache key, but if the engine (now entity) name contains numbers (such as tts.piper_2) the following happens:

  1. The TTS audio is generated, cached, and written to the file system correctly
  2. Requests for the cached audio will fail because the non-legacy regex fails to match the engine

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, @pvizeli, mind taking a look at this pull request as it has been labeled with an integration (tts) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tts can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tts Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@synesthesiam synesthesiam marked this pull request as ready for review April 25, 2023 20:40
@synesthesiam synesthesiam requested review from a team and pvizeli as code owners April 25, 2023 20:40
@synesthesiam synesthesiam requested a review from frenck April 26, 2023 00:32
@balloob balloob merged commit 257944c into dev Apr 26, 2023
@balloob balloob deleted the tts-engine-in-cache-key branch April 26, 2023 04:33
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants