Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add media_player platform to Android TV Remote #91677

Merged
merged 21 commits into from
May 6, 2023
Merged

Add media_player platform to Android TV Remote #91677

merged 21 commits into from
May 6, 2023

Conversation

Drafteed
Copy link
Contributor

@Drafteed Drafteed commented Apr 19, 2023 •
edited
Loading

Proposed change

This PR adds the media_player platform to the new Android TV Remote integration.

Bump androidtvremote2 package to v0.0.8.
Changelog: tronikos/androidtvremote2@v0.0.7...v0.0.8

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @tronikos, mind taking a look at this pull request as it has been labeled with an integration (androidtv_remote) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of androidtv_remote can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign androidtv_remote Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@Drafteed Drafteed changed the title Atvremote media player Add media_player platform to Android TV Remote Apr 19, 2023
@Drafteed Drafteed marked this pull request as draft April 19, 2023 14:00
@Drafteed Drafteed mentioned this pull request Apr 19, 2023
Merged
8 tasks
Drafteed
Drafteed commented Apr 19, 2023
View reviewed changes
CODEOWNERS Show resolved Hide resolved
homeassistant/components/androidtv_remote/const.py Outdated Show resolved Hide resolved
@Drafteed Drafteed marked this pull request as ready for review April 19, 2023 14:16
tronikos
tronikos requested changes Apr 20, 2023
View reviewed changes
homeassistant/components/androidtv_remote/const.py Outdated Show resolved Hide resolved
homeassistant/components/androidtv_remote/entity.py Outdated Show resolved Hide resolved
homeassistant/components/androidtv_remote/entity.py Show resolved Hide resolved
homeassistant/components/androidtv_remote/__init__.py Outdated Show resolved Hide resolved
tests/components/androidtv_remote/conftest.py Outdated Show resolved Hide resolved
homeassistant/components/androidtv_remote/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/androidtv_remote/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/androidtv_remote/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/androidtv_remote/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/androidtv_remote/media_player.py Outdated Show resolved Hide resolved
@frenck frenck requested a review from tronikos April 22, 2023 12:07
tronikos
tronikos requested changes Apr 24, 2023
View reviewed changes
homeassistant/components/androidtv_remote/entity.py Show resolved Hide resolved
homeassistant/components/androidtv_remote/entity.py Outdated Show resolved Hide resolved
homeassistant/components/androidtv_remote/entity.py Outdated Show resolved Hide resolved
homeassistant/components/androidtv_remote/entity.py Outdated Show resolved Hide resolved
homeassistant/components/androidtv_remote/entity.py Outdated Show resolved Hide resolved
homeassistant/components/androidtv_remote/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/androidtv_remote/media_player.py Show resolved Hide resolved
tests/components/androidtv_remote/test_media_player.py Outdated Show resolved Hide resolved
tests/components/androidtv_remote/test_media_player.py Outdated Show resolved Hide resolved
tests/components/androidtv_remote/test_media_player.py Show resolved Hide resolved
@frenck frenck marked this pull request as draft April 24, 2023 16:53
@frenck
Copy link
Member

frenck commented Apr 24, 2023

I've marked this PR, as changes are requested that need to be processed.
Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

../Frenck

Learn more about our pull request process.

@Drafteed Drafteed requested a review from tronikos May 5, 2023 15:26
@Drafteed Drafteed mentioned this pull request May 5, 2023
Closed
@Shahzadimalik

This comment was marked as spam.

Sign in to view
bdraco
bdraco requested changes May 5, 2023
View reviewed changes
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. There is one small problem that needs to be worked out
https://github.com/home-assistant/core/pull/91677/files#r1186535872

@home-assistant
Copy link

home-assistant bot commented May 5, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 5, 2023 22:28
@Drafteed Drafteed marked this pull request as ready for review May 5, 2023 23:34
@home-assistant home-assistant bot requested review from bdraco and tronikos May 5, 2023 23:34
bdraco
bdraco approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Drafteed

@tronikos
Copy link
Member

tronikos commented May 6, 2023

I think it would be better to remove the volume_set functionality for now until this is tested on devices with external audio. I can do the testing this or next weekend.

@bdraco
Copy link
Member

bdraco commented May 6, 2023

That’s a good idea. It will be a lot faster to merge a follow up small pr

@Drafteed
Copy link
Contributor Author

Drafteed commented May 6, 2023

I think it would be better to remove the volume_set functionality for now until this is tested on devices with external audio. I can do the testing this or next weekend.

Done!

@bdraco
Copy link
Member

bdraco commented May 6, 2023

It looks like the docs PR will need a tweak as well
home-assistant/home-assistant.io#27059

@Drafteed
Copy link
Contributor Author

Drafteed commented May 6, 2023

It looks like the docs PR will need a tweak as well

Sorry, I didn’t really understand what exactly requires a tweak in the documentation? Volume control remains possible through the volume_up/volume_down/volume_mute methods.

@bdraco
Copy link
Member

bdraco commented May 6, 2023

It looks like the docs PR will need a tweak as well

Sorry, I didn’t really understand what exactly requires a tweak in the documentation? Volume control remains possible through the volume_up/volume_down/volume_mute methods.

My bad. I went back and looked again and it still makes sense.

@bdraco bdraco merged commit d816da9 into home-assistant:dev May 6, 2023
@Drafteed
Copy link
Contributor Author

Drafteed commented May 6, 2023

Thanks, @tronikos!
Thanks, @bdraco!

@Drafteed Drafteed deleted the atvremote-media-player branch May 6, 2023 14:19
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2023
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@se-bastiaan se-bastiaan se-bastiaan left review comments

@mvdwetering mvdwetering mvdwetering left review comments

@bdraco bdraco bdraco approved these changes

@tronikos tronikos Awaiting requested review from tronikos tronikos is a code owner

Assignees
No one assigned
Labels
cla-signed code-owner-approved has-tests integration: androidtv_remote new-feature new-platform noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: platinum
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Drafteed @frenck @Shahzadimalik @tronikos @bdraco @mvdwetering @se-bastiaan