Allow config entries unload action to be coroutine #91531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
core
new-feature
small-pr
|
I have missed this feature in unload. Making sure io bound things are fully closed down too make sense to me. |
elupus
added
the
second-opinion-wanted
elupus
approved these changes
Apr 17, 2023
balloob
reviewed
Apr 17, 2023
| """Process the on_unload callbacks and wait for pending tasks.""" | ||
| if self._on_unload is not None: | ||
| while self._on_unload: | ||
| self._on_unload.pop()() | ||
| if job := self._on_unload.pop()(): | ||
| self._tasks.add(hass.async_create_task(job)) |
There was a problem hiding this comment.
This would pass a callback function to async_create_task ?
There was a problem hiding this comment.
No it shouldn't: see the double () in the pop.
Would that be clearer?
callback = self._on_unload.pop()
if job := callback():
self._tasks.add(hass.async_create_task(job))
balloob
approved these changes
Apr 17, 2023
balloob
removed
the
second-opinion-wanted
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Allow config entries unload action to be coroutine
Linked to #91439 and #91456
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: