Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump onvif-zeep-async to 1.2.5 #91399

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Bump onvif-zeep-async to 1.2.5 #91399

merged 2 commits into from
Apr 14, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 13, 2023

Proposed change

relaxes ssl requirements for older cameras
reverts and replaces fix for ssl context leak with an alternate solution as it had too much collateral breakage and its unlikely agronholm/anyio#374 is going to be fixed soon

changes: openvideolibs/python-onvif-zeep-async@4bf547c...v1.2.5

Thanks to @denpamusic via #91398 for testing the fixes since I wasn't able to acquire an affected device after a few failed attempts at buying one off ebay

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @hunterjm, mind taking a look at this pull request as it has been labeled with an integration (onvif) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of onvif can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign onvif Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco marked this pull request as ready for review April 13, 2023 23:50
@bdraco bdraco requested a review from hunterjm as a code owner April 13, 2023 23:50
@bdraco bdraco changed the title Bump onvif-zeep-async to 1.2.4 Bump onvif-zeep-async to 1.2.5 Apr 14, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit 025e179 into dev Apr 14, 2023
@frenck frenck deleted the onvif_ssl_relax branch April 14, 2023 06:37
@bdraco
Copy link
Member Author

bdraco commented Apr 14, 2023

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants