Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hass test fixture async #91264

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Make hass test fixture async #91264

merged 4 commits into from
Apr 12, 2023

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Apr 12, 2023

Proposed change

Make hass test fixture async

Linked to #90850

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@epenet epenet marked this pull request as draft April 12, 2023 08:24
@epenet epenet marked this pull request as ready for review April 12, 2023 10:13
Comment on lines 489 to 490
# This wraps the async _hass fixture inside a sync fixture, to avoid issues with
# ContextVar, see https://github.com/pytest-dev/pytest-asyncio/issues/127
Copy link
Contributor

@emontnemery emontnemery Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be more precise than "issues with contextvar"?
I guess what we need is to ensure the hass context variable is set in the execution context in which the test itself is executed, maybe we can try to explain that?

@frenck frenck merged commit d483ad8 into home-assistant:dev Apr 12, 2023
@epenet epenet deleted the hass-fixture branch April 13, 2023 04:34
tkhadimullin pushed a commit to tkhadimullin/ha-core that referenced this pull request Apr 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants