Skip to content

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Apr 10, 2023

Breaking change

UniFi integration no longer provides both hostname and host_name attributes for a client tracker entity, only host_name will be provided as an attribute.

Proposed change

Was revisiting reported issues and noticed that host_name wasn't provided after the client refactor. This PR fixes that and also removes the pointed out unnecessary duplicate.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kane610 👍

../Frenck

@frenck frenck merged commit 0d7711f into home-assistant:dev Apr 11, 2023
@Kane610 Kane610 deleted the unifi-fix_client_tracker_hostname branch April 11, 2023 18:10
@Kane610
Copy link
Member Author

Kane610 commented Apr 11, 2023

Awesome! Thanks @frenck 🎉

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hostname &host_name on device_trackers
2 participants