Make repairs out of select supervisor issues #90893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
core
has-tests
integration: hassio
new-feature
labels
|
Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
mdegat01
force-pushed
the
supervisor-issues-to-repairs
branch
from
06e0014 to
477686f
Compare
mdegat01
force-pushed
the
supervisor-issues-to-repairs
branch
2 times, most recently
from
a0aba6e to
fd0d18d
Compare
ludeeus
reviewed
Apr 12, 2023
mdegat01
force-pushed
the
supervisor-issues-to-repairs
branch
from
fd0d18d to
08d552b
Compare
mdegat01
force-pushed
the
supervisor-issues-to-repairs
branch
from
08d552b to
2caabdb
Compare
emontnemery
approved these changes
Apr 19, 2023
| return f"{self.context}_{self.type_}" | ||
|
|
||
| @staticmethod | ||
| def from_dict(data: SuggestionDataType) -> Suggestion: |
There was a problem hiding this comment.
This method can preferably be a classmethod as it returns an instance of the class.
| return f"issue_{self.context}_{self.type_}" | ||
|
|
||
| @staticmethod | ||
| def from_dict(data: IssueDataType) -> Issue: |
| severity=IssueSeverity.WARNING, | ||
| translation_key=issue.key, | ||
| translation_placeholders={PLACEHOLDER_KEY_REFERENCE: issue.reference} | ||
| if issue.reference |
There was a problem hiding this comment.
Ternary operator expressions that span more than one line are hard to read.
|
|
||
| async def async_step_init(self, _: None = None) -> FlowResult: | ||
| """Handle the first step of a fix flow.""" | ||
| # Got out of sync with supervisor, issue is resolved or isn't fixable. Either way, resolve the repair |
There was a problem hiding this comment.
Please break long strings and comments around 88 characters per line.
| data = await self._client.get_resolution_info() | ||
| self.unhealthy_reasons = set(data[ATTR_UNHEALTHY]) | ||
| self.unsupported_reasons = set(data[ATTR_UNSUPPORTED]) | ||
|
|
||
| # Remove any cached issues that weren't returned | ||
| for issue_id in set(self._issues.keys()) - { |
There was a problem hiding this comment.
Copying a dict to a set uses the keys by default. We can remove .keys().
20 tasks
frenck
added
the
noteworthy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
As of home-assistant/supervisor#4218 Supervisor is now creating an issue when it detects multiple filesystems with the name
hassos-data. Because that creates a race condition at system startup, since OS uses the first filesystem it sees with the namehassos-dataas the data disk.In addition home-assistant/supervisor#3984 added a new "reboot required" supervisor issue created when a user adjusts settings on their board as those require a system reboot to take effect.
Currently these supervisor issues are buried in the CLI. This PR adds support for easily turning supervisor issues into repairs and applying supervisor's suggestions to fix them. It contains a hard-coded list of which issues should be presented as repairs so we can evaluate each on a case-by-case basis. For now only the two described above will be presented as repairs.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: