Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move local calendar diagnostics to pytest.mark.freezetime #90886

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Move local calendar diagnostics to pytest.mark.freezetime #90886

merged 1 commit into from
Apr 6, 2023

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Apr 6, 2023 •
edited
Loading

Proposed change

This reverts the changes in #90134 which do not appear to be needed once the test is moved from @freeze_time to @pytest.mark.freeze_time

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@allenporter allenporter requested a review from bdraco April 6, 2023 00:04
@allenporter allenporter merged commit a019529 into home-assistant:dev Apr 6, 2023
@bdraco bdraco mentioned this pull request Apr 6, 2023
Merged
bdraco added a commit that referenced this pull request Apr 6, 2023
@bdraco
Revert "Move local calendar diagnostics to pytest.mark.freezetime (#9…
a295055 
…0886)"

This reverts commit a019529.
@bdraco
Copy link
Member

bdraco commented Apr 6, 2023

I'm not sure why it didn't fail this run but all the full CI runs are failing again.

I opened #90899 if we want to do a revert to get things back in good shape unless you have a quick fix?

allenporter pushed a commit that referenced this pull request Apr 6, 2023
@bdraco
Revert "Move local calendar diagnostics to pytest.mark.freezetime" (#…
479a35c 
…90899)

Revert "Move local calendar diagnostics to pytest.mark.freezetime (#90886)"

This reverts commit a019529.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed code-quality has-tests integration: local_calendar Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allenporter @bdraco