-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image entity component #90564
Add image entity component #90564
Conversation
61ab7e4
to
344af22
Compare
344af22
to
630e2d9
Compare
I like this simpler standalone image entity! I'm curious to understand the plan for the existing camera or even just generic specifically. The PR description mentions the existing generic camera integration, which my impression can handle this case already, but it brings in other stuff. Is the plan to migrate existing use cases or share implementation? Generally, camera has no path for evolution and is kind of stuck as some virtual entity thing but it's really doing too much and is effectively multiple separate |
The driver for this PR is integrations using the camera entity for things like #80810, modeling that as a "camera" is a really poor fit. The reference to the |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
../Frenck
Proposed change
Add
image
entity componentThis is a greatly simplified version of
camera
which only supports serving a static image.Frontend support: home-assistant/frontend#16877
In follow-up PRs:
generic
camera for displaying an image from a URLimage
platform to thetemplate
integrationType of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: