-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add camera platform to Freebox #88104
Conversation
Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hello, |
Also you do not seem to have updated units tests https://github.com/home-assistant/core/tree/dev/tests/components/freebox |
I'm working on... 75% covered |
I'm marking this as draft, please set to ready for review when the tests have been updated 👍 |
88% is enough?
|
I was looking for answers in the documentation but I do not find any specified value except the use of the word full. But I guess it's enough, since there is tests and they do work it's fine. |
Ok, good... |
There is a button somewhere to flag it ready for reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes to be made.
Thanks to start implementing the Home API of the Freebox.
Fill the "Proposed change" section of the PR and your plan for implementing all Freebox Home sensors.
add code corrections after PR review Co-authored-by: Quentame <polletquentin74@me.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at your documentation PR review: home-assistant/home-assistant.io#26669
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Breaking change
Proposed change
Plan for implementing all Freebox Home sensors (cameras, pir,dws,remote commands..) and alarm system.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: