Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change geniushub codeowner #87918

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Conversation

zxdavb
Copy link
Contributor

@zxdavb zxdavb commented Feb 12, 2023

Proposed change

This PR changes the codeowner of this integration from myself to the new maintainer of its client library.

Although I wrote the initial implementation of the geniushub client library, I have now handed the repo (and the pypi package) over to @manzanotti:

He has previously agreed to be the codeowner for this integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@zxdavb zxdavb changed the title change codeowner (meta files) change codeowner Feb 12, 2023
@zxdavb zxdavb changed the title change codeowner change geniushub codeowner Feb 12, 2023
@zxdavb zxdavb marked this pull request as ready for review February 12, 2023 04:12
@MartinHjelmare MartinHjelmare changed the title change geniushub codeowner Change geniushub codeowner Feb 12, 2023
@frenck
Copy link
Member

frenck commented Feb 12, 2023

@manzanotti Are you ok with you being added?

Marking this PR draft until we have confirmation.

../Frenck

@frenck frenck marked this pull request as draft February 12, 2023 17:20
@manzanotti
Copy link
Contributor

@manzanotti Are you ok with you being added?

Marking this PR draft until we have confirmation.

../Frenck

Hi @frenck I am happy being added, thanks.

@frenck frenck marked this pull request as ready for review February 13, 2023 11:11
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @zxdavb 👍

../Frenck

@frenck frenck merged commit dc8ceaf into home-assistant:dev Feb 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2023
@zxdavb zxdavb deleted the change-genius-owner branch November 6, 2023 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants