Improve rainbird device reliability by sending requests serially #87603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Update the rainbird coordinator to send requests serially, rather than in parallel.
Rainbird devices will often return a 503 to indicate the device is busy when it can't handle multiple requests at the same time, and we can see from device logs that it is likely to drop one of the requests when sending multiple at the same time.
This also simplifies some of the code to use newer APIs that are easier to use (the API now returns a set directly, rather than just having a method to check if an item is in the set). Also, one call previously was memoized in home assistant can now use memoization baked into the client (e.g. total number of stations, which does not change)
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: