Move I/O outside of properties for light/tplink platform #8699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gollo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @robbiet480 to be potential reviewers. |
balloob
approved these changes
Jul 30, 2017
|
Thanks! 🐬 |
|
For your next PR, please start a new branch forked off the dev branch. |
|
Okay, will do. Sorry about that. |
balloob
pushed a commit
that referenced
this pull request
Jul 31, 2017
* Add new component for TPLink light bulbs. * Update with result of gen_requirements_all. * Add new component light.tplink. * Move I/O outside of properties as per https://goo.gl/Nvioub.
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
…ant#8699) * Add new component for TPLink light bulbs. * Update with result of gen_requirements_all. * Add new component light.tplink. * Move I/O outside of properties as per https://goo.gl/Nvioub.
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Platform reporting too long getting properties as described in https://goo.gl/Nvioub.
Moved the offending I/O into the update function.
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests pass[ ] New dependencies have been added to theREQUIREMENTSvariable (example).[ ] New dependencies are only imported inside functions that use them (example).[ ] New dependencies have been added torequirements_all.txtby runningscript/gen_requirements_all.py.[ ] New files were added to.coveragerc.