Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rympro integration code fixes #86734

Merged
merged 5 commits into from
Jan 31, 2023
Merged

Conversation

OnFreund
Copy link
Contributor

Proposed change

Address code review comments from #85986

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@OnFreund
Copy link
Contributor Author

Also added @elad-bar and @maorcc as code owners.

@thecode thecode mentioned this pull request Jan 26, 2023
19 tasks
@thecode thecode mentioned this pull request Jan 26, 2023
19 tasks
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typing suggestions from #86737. That will help type coordinator.data

homeassistant/components/rympro/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/rympro/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/rympro/coordinator.py Outdated Show resolved Hide resolved
OnFreund and others added 2 commits January 26, 2023 20:43
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
@OnFreund OnFreund requested a review from thecode January 28, 2023 10:58
@thecode thecode added the smash Indicator this PR is close to finish for merging or closing label Jan 28, 2023
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 35b82db into home-assistant:dev Jan 31, 2023
@OnFreund OnFreund deleted the rympro_review branch January 31, 2023 09:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants