Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Almond integration #86616

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Remove Almond integration #86616

merged 1 commit into from
Jan 25, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Jan 25, 2023

Breaking change

Removes the almond integration. It is in a non-working state, and the services have been shut down.

Proposed change

Removes the almond integration. It is in a non-working state, the services have been shut down and the website only shows:

CleanShot 2023-01-25 at 11 34 06

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @gcampax, @balloob, mind taking a look at this pull request as it has been labeled with an integration (almond) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of almond can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign almond Removes the current integration label and assignees on the issue, add the integration domain after the command.

@frenck frenck merged commit 5f1edbc into dev Jan 25, 2023
@frenck frenck deleted the frenck-2023-0195 branch January 25, 2023 11:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants