Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component Light TPLink #8643

Merged
merged 3 commits into from
Jul 26, 2017
Merged

Add component Light TPLink #8643

merged 3 commits into from
Jul 26, 2017

Conversation

gollo
Copy link
Contributor

@gollo gollo commented Jul 25, 2017

Description:

Adds a new light component for TPLink bulbs.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#3055

Example entry for configuration.yaml (if applicable):

# Example configuration.yaml entry
light:
  - platform: tplink
    host: IP_ADDRESS

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@myusuf3
Copy link

myusuf3 commented Jul 26, 2017

Reviewed. 👍 @balloob maybe get a merge on this after your thoughts.

Copy link

@myusuf3 myusuf3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pvizeli pvizeli merged commit e83816c into home-assistant:dev Jul 26, 2017
@gollo gollo deleted the light_tplink branch July 26, 2017 07:13
@balloob balloob mentioned this pull request Jul 29, 2017
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
* Add new component for TPLink light bulbs.

* Update with result of gen_requirements_all.

* Add new component light.tplink.
@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants