Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add easyEnergy integration #86266

Merged
merged 8 commits into from
Feb 3, 2023
Merged

Conversation

klaasnicolaas
Copy link
Member

@klaasnicolaas klaasnicolaas commented Jan 20, 2023

Proposed change

A new integration that uses the data from easyEnergy, interesting for those who have a dynamic energy contract.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot like energy_zero, which I guess helped a lot with creating this one 😄

Tested locally and works as expected. Code looks good 👍
Nice job!

../Frenck

@frenck frenck merged commit 3723241 into home-assistant:dev Feb 3, 2023
@epenet
Copy link
Contributor

epenet commented Feb 3, 2023

This is blocking #87068
Do you feel like taking a look?

@epenet
Copy link
Contributor

epenet commented Feb 3, 2023

Warning: homeassistant/components/easyenergy/coordinator.py:36:23: W7431: Argument hass should be of type ['HomeAssistant', 'HomeAssistant | None'] in __init__ (hass-argument-type)

@klaasnicolaas
Copy link
Member Author

Wouldn't it be easier to include the adjustment in your own pull request?

@epenet
Copy link
Contributor

epenet commented Feb 3, 2023

Possibly... but not sure if I will get a chance before Monday.

@frenck frenck mentioned this pull request Feb 4, 2023
19 tasks
@frenck
Copy link
Member

frenck commented Feb 4, 2023

Fixed in #87371

@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants