-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reauth config flow to honeywell #86170
Add Reauth config flow to honeywell #86170
Conversation
Hey there @rdfurman, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Not sure I fully understand what is being implemented here. Is this going to make HASS request the user enter their password again when an authentication error happens for a honeywell integration that has already been added? The PR description could use a little more detail IMO. It would go a long way with helping me understand what you're adding here. I usually show a screenshot of what the config window now looks like when making changes to the config flow as well. |
@rdfurman : Yes, it adds the "standard" config flow for re-authorization when the API reports a password error when the platform attempts to initialize. I'm surprised it made it in without it. (It was required on one of my first integrations). Without this flow, the user MUST remove the integration to change the password. |
LGTM now that it has 100% coverage. |
Yah - the coverage problem wasn't in our code, something in another integration slid into the dev branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, but i've not done any reauth flows.
Do we get a merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed change
Type of change
Add reauth config flow to Honeywell integration
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: