Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filters to climate and light service descriptions #86162

Merged
merged 8 commits into from
Mar 16, 2023
Merged

Add filters to climate and light service descriptions #86162

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
44d235f
Add filters to climate and light service descriptions
emontnemery Jan 18, 2023
71966b1
Allow specifying enums directly
emontnemery Mar 14, 2023
be98ec9
Update service descriptions
emontnemery Mar 14, 2023
218f20f
Adjust test
emontnemery Mar 14, 2023
ba5dee2
Cache entity features
emontnemery Mar 15, 2023
798dbed
Lint
emontnemery Mar 15, 2023
b041f64
Improve error handling, add list of known base components
emontnemery Mar 15, 2023
b69c2df
Don't allow specifying an entity feature as int
emontnemery Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust test
  • Loading branch information
@emontnemery
emontnemery committed Mar 14, 2023
commit 218f20f2950bc2be38456f97c0140b4eb504045c
6 changes: 3 additions & 3 deletions tests/helpers/test_selector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def test_device_selector_schema(schema, valid_selections, invalid_selections) ->
(
{
"filter": [
{"supported_features": ["LightEntityFeature.EFFECT"]},
{"supported_features": ["light.LightEntityFeature.EFFECT"]},
]
},
("light.abc123", "blah.blah", FAKE_UUID),
Expand Down Expand Up @@ -258,9 +258,9 @@ def test_entity_selector_schema(schema, valid_selections, invalid_selections) ->
# Invalid feature
{"filter": [{"supported_features": ["blah"]}]},
# Unknown feature enum
{"filter": [{"supported_features": ["FooEntityFeature.blah"]}]},
{"filter": [{"supported_features": ["blah.FooEntityFeature.blah"]}]},
# Unknown feature enum member
{"filter": [{"supported_features": ["LightEntityFeature.blah"]}]},
{"filter": [{"supported_features": ["light.LightEntityFeature.blah"]}]},
),
)
def test_entity_selector_schema_error(schema) -> None:
Expand Down