Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds uk_transport component #8600

Merged
merged 2 commits into from
Jul 26, 2017
Merged

Adds uk_transport component #8600

merged 2 commits into from
Jul 26, 2017

Conversation

robmarkcole
Copy link
Contributor

Description:

Adds uk_transport component which provides sensors for bus and train departure times.

**Pull request in home-assistant/home-assistant.io#3037

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: uk_transport
    app_id: !secret uk_transport_app_id
    app_key: !secret uk_transport_app_key
    queries:
      - mode: bus
        origin: 340000368SHE
        destination: Wantage
      - mode: train
        origin: MAL
        destination: WIM

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • [ x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • [x ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • [x ] Tests have been added to verify that the new code works.

Copy link
Member

@lwis lwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@lwis
Copy link
Member

lwis commented Jul 26, 2017

This can be merged once the lint is fixed.

@robmarkcole
Copy link
Contributor Author

Hi @lwis had the same issue with #8272 by @balloob merged anyway without issue. Please advise. Cheers

@balloob
Copy link
Member

balloob commented Jul 26, 2017

@robmarkcole that's not true. For #8272 it was a flaky test on Python 3.6. If you look at the build results now, there is a linting error which needs to be addressed.

@robmarkcole
Copy link
Contributor Author

@balloob you are correct, should be fixed now

@lwis lwis merged commit 3b4ea86 into home-assistant:dev Jul 26, 2017
@lwis
Copy link
Member

lwis commented Jul 26, 2017

Thanks! 🐊

@balloob balloob mentioned this pull request Jul 29, 2017
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants