Deprecate ISY994 custom cleanup entities service

[shbatm]

Breaking change

The isy994.cleanup_entities service is being deprecated and will be removed in 2023.5.0. Entities are automatically cleaned up when the integration is loaded or reloaded.

Proposed change

Deprecate the isy994.cleanup_entities service is being deprecated and will be removed in 2023.5.0. Entities are automatically cleaned up when the integration is loaded or reloaded as of #85744), the custom service is no longer needed.

Note: I am leaving the isy994.reload service for now--ultimately this can be removed if a core service is added to reload an integration from a service call.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: Deprecate ISY994 custom cleanup entities service home-assistant.io#25761

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (isy994) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of isy994 can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Change the title of the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign isy994 Removes the current integration label and assignees on the issue, add the integration domain after the command.

[bdraco]

Note: I am leaving the isy994.reload service for now--ultimately this can be removed if a core service is added to reload an integration from a service call.

We already have a service to reload a config entry so we can drop the isy994.reload service. https://www.home-assistant.io/integrations/homeassistant/#service-homeassistantreload_config_entry

[shbatm]

I missed that somehow. I remembered the architecture discussion and thought it had stalled. Will deprecate.