Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for streaming (push) history #85892

Merged
merged 39 commits into from
Jan 22, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 14, 2023

frontend: home-assistant/frontend#15112

Proposed change

Currently we poll for history data; like logbook we can stream this data to avoid database overhead. This change will allow us to update the frontend places that use cached-history so we can drop it. This change stems from the discussion in home-assistant/frontend#12873 (comment)

This will fix all the dropped states issues we have with cached history since commits are not instant. Currently we assume the data is always there after 1s (default commit interval) but its not always there since the backend API makes no guarantee about when the data will be available (we could be processing stats, or doing a purge, etc) so we tend to drop values which results in lots of unexplained history issues. This implementation can completely replace the cached history used on the frontend and it will never touch the database after the first queries to catch up.

Cc @agners I think this is the last piece we need before we can bump the commit internal to 3s (maybe 5s) and finally realize some more of the IO and flash lifetime savings from your testing

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Currently we poll for history data, like logbook we can stream
this data to avoid database overhead
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (history) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of history can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign history Removes the current integration label and assignees on the issue, add the integration domain after the command.

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

bdraco added a commit to bdraco/home-assistant that referenced this pull request Jan 22, 2023
@balloob balloob merged commit 8227c84 into home-assistant:dev Jan 22, 2023
@bdraco bdraco added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Jan 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core integration: history noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants