Enable/Disable Motion detection for Foscam Cameras #8582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…This support was added in 0.48.1 as a generic service for cameras. Motion detection can be enabled/disabled for foscam cameras with this code-set.
…od statement for pydocstyle
…lk to foscam, used a 3rd party foscam library to communicate with it. This library already has support to enable/disable motion detection and also APIs to change the motion detection schedule etc. Need to add more support in the pyfoscam 3rd party library for checking if motion was detected or even if sound was detected. Once that is done, we can add that into HASS as well.
|
@viswa-swami, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ishults, @SEJeff and @fabaff to be potential reviewers. |
houndci-bot
reviewed
Jul 21, 2017
|
|
||
| _LOGGER.info("Using the following URL for %s: %s", | ||
| self._name, uri_template.format('***', '***')) | ||
| self._foscam_session = FoscamCamera(ip_address, port, self._username, self._password) |
There was a problem hiding this comment.
line too long (93 > 79 characters)
balloob
approved these changes
Jul 24, 2017
|
Ok to merge once the lint and requirement builds pass. See Travis details for issues. |
myusuf3
reviewed
Jul 26, 2017
There was a problem hiding this comment.
you need to remove the requests import and this should be good to go. Since you aren't using it anymore @viswa-swami
myusuf3
reviewed
Jul 26, 2017
| def camera_image(self): | ||
| """Return a still image reponse from the camera.""" | ||
| # Send the request to snap a picture and return raw jpg data | ||
| # Handle exception if host is not reachable or url failed | ||
| try: | ||
| response = requests.get(self._snap_picture_url, timeout=10) |
There was a problem hiding this comment.
You need to remove import requests above for tests to pass.
…t that i have. Generated using the gen_requirements_all.py script
… by gen_requirements_all.py after latest pull from origin/dev
houndci-bot
reviewed
Jul 31, 2017
| self._name, uri_template.format('***', '***')) | ||
| from foscam import FoscamCamera | ||
|
|
||
| self._foscam_session = FoscamCamera(ip_address, port, self._username, self._password) |
There was a problem hiding this comment.
line too long (93 > 79 characters)
|
Awesome 🎉 🐬 |
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* Added support to enable/disable motion detection for foscam cameras. This support was added in 0.48.1 as a generic service for cameras. Motion detection can be enabled/disabled for foscam cameras with this code-set. * Fixed the violation identified by hound-bot * Fixed the comment posted by HoundCI-Bot regarding using imperative mood statement for pydocstyle * Fixed the error that travis-ci bot found. * As per comment from @balloob, Instead of directly using the URL to talk to foscam, used a 3rd party foscam library to communicate with it. This library already has support to enable/disable motion detection and also APIs to change the motion detection schedule etc. Need to add more support in the pyfoscam 3rd party library for checking if motion was detected or even if sound was detected. Once that is done, we can add that into HASS as well. * Lint * Removed the requests library import which is not used anymore * Updating requirements_all.txt based on the code-base of home assistant that i have. Generated using the gen_requirements_all.py script * Updating requirements_all.txt and requirements_test_all.txt generated by gen_requirements_all.py after latest pull from origin/dev * Updated requirements_all.txt with script * Updated the foscam camera code to fix lint errors * Fixed houndci violation
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Enable_Motion_Detection and Disable_Motion_Detection were services added to the Camera component in 0.48.1.
Support was added for Arlo cameras in one of the earlier releases. Now adding support for Foscam cameras to enable/disable motion detection.
Based on comments from @balloob, I have changed the code to use a foscam 3rd party library instead of implementing the foscam protocol in HASS.
Updated the requirements_all.txt to reflect the pyfoscam dependency/requirement.
This code has been tested with foscam camera in my home.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass