Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly intents in nightly builds #85806

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Fix nightly intents in nightly builds #85806

merged 1 commit into from
Jan 13, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Jan 13, 2023

Proposed change

Fixes the addition of nightly intents in our nightly builds. Originally added in #85760.

#85760 is working fine; however, I forgot actually to add the Dockerfile changes, meaning everything works right, but the nightly intents aren't installed and resulting in a failing build.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added bugfix cla-signed small-pr PRs with less than 30 lines. labels Jan 13, 2023
@frenck
Copy link
Member Author

frenck commented Jan 13, 2023

The pytest fail because of an issue with the ubuntu apt repos @ Azure. This PR isn't changing anything that will affect or show up in Pytest. I will therefore continue the merge in order to be able to move against with shipping a nightly build.

../Frenck

@frenck frenck merged commit 80714c5 into dev Jan 13, 2023
@frenck frenck deleted the frenck-2023-0089 branch January 13, 2023 08:56
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants