Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oralb to show battery percentage #85800

Merged
merged 8 commits into from
Jan 13, 2023

Conversation

Lash-L
Copy link
Contributor

@Lash-L Lash-L commented Jan 13, 2023

Proposed change

Adds support for active-ble connections, which allow us to get the battery_percentage of a device.
Adds support for various oral-b devices
Corrects 'Unknown pressure' issues
Updated to oralb-ble 0.17.1
Changes: Bluetooth-Devices/oralb-ble@v0.14.3...v0.17.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hi conway220

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (oralb) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of oralb can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign oralb Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bdraco bdraco changed the title Oralb active ble Update oralb to show battery percentage Jan 13, 2023
@Lash-L
Copy link
Contributor Author

Lash-L commented Jan 13, 2023

@bdraco when you have a chance can you take a look at my test and tell me what I am doing wrong. I am not getting any data for the battery. The service data is ripped straight from the debugger

@bdraco
Copy link
Member

bdraco commented Jan 13, 2023

@bdraco when you have a chance can you take a look at my test and tell me what I am doing wrong. I am not getting any data for the battery. The service data is ripped straight from the debugger

I added mocks for the battery read

@bdraco
Copy link
Member

bdraco commented Jan 13, 2023

Screenshot 2023-01-13 at 10 02 30 AM

Testing looks good

@Lash-L
Copy link
Contributor Author

Lash-L commented Jan 13, 2023

Same on my side

image

@bdraco bdraco merged commit 67716ed into home-assistant:dev Jan 13, 2023
@bdraco
Copy link
Member

bdraco commented Jan 13, 2023

Thanks @conway220

@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2023
@home-assistant home-assistant unlocked this conversation Jan 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2023
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dependency integration: oralb new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: No score
Projects
None yet
4 participants