Use device-native kelvins for tplink color temperature

[rytilahti]

Proposed change

This PR converts tplink's light platform to use device-native kelvins for color temperature handling which allows getting rid of mired<->kelvin conversions.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Change the title of the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign tplink Removes the current integration label and assignees on the issue, add the integration domain after the command.

[rytilahti]

I have no clue why the mypy is still failing:

Error: homeassistant/components/tplink/light.py:216: error: Argument "transition" to "turn_on" of "SmartBulb" has incompatible type "Optional[int]"; expected "int" [arg-type]

The variable in question on 216 is typed to be optional:

    async def _async_turn_on_with_brightness(
        self, brightness: int | None, transition: int | None
    ) -> None:
        # Fallback to adjusting brightness or turning the bulb on
        if brightness is not None:
            await self.device.set_brightness(brightness, transition=transition)
            return
        await self.device.turn_on(transition=transition)

which is what the upstream library also expects: https://github.com/python-kasa/python-kasa/blob/master/kasa/smartbulb.py#L483

edit: Potentially related to the use of implicit optionals (https://github.com/python-kasa/python-kasa/blob/0.5.0/kasa/smartbulb.py#L382) which was fixed in python-kasa/python-kasa#401 that has not yet been released.

Any ideas for the simplest fix without preparing a new release?

[rytilahti]

python-kasa 0.5.0 uses implicit optionals causing mypy to fail, this should get fixed when #88416 gets merged and this PR gets rebased.

edit: looks like that fixes it, so after the bump PR gets merged I'll rebase this again on top of the dev.

[bdraco]

I think this looks good. Need to find time to test it

[bdraco]

Tested with

KL125(US)
by TP-Link
Firmware: 1.0.7 Build 210811 Rel.171439
Hardware: 2.0

👍

[bdraco]

Thanks @rytilahti

[bdraco]

Also did some more testing with the 5s update interval.. seems like it will be just fine 😉

[bdraco]

If there someone with hundreds of bulbs in production it might be worth changing out json for orjson here:

https://github.com/python-kasa/python-kasa/blob/6be2f387f04867b1af554cf25c674425f8d0e1d9/kasa/protocol.py#L99
https://github.com/python-kasa/python-kasa/blob/6be2f387f04867b1af554cf25c674425f8d0e1d9/kasa/protocol.py#L67