-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ISY994 variables as number entities #85511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
breaking-change
cla-signed
deprecation
Indicates a breaking change to happen in the future
integration: isy994
new-feature
new-platform
labels
Jan 9, 2023
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
8 tasks
bdraco
reviewed
Jan 9, 2023
bdraco
reviewed
Jan 9, 2023
bdraco
reviewed
Jan 9, 2023
bdraco
reviewed
Jan 10, 2023
Testing this now |
Co-authored-by: J. Nick Koston <nick@koston.org>
19 tasks
bdraco
reviewed
Jan 10, 2023
bdraco
reviewed
Jan 10, 2023
bdraco
approved these changes
Jan 10, 2023
Tested 👍 |
Also validated that variables can only be numbers |
Thanks @shbatm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
breaking-change
by-code-owner
cla-signed
deprecation
Indicates a breaking change to happen in the future
integration: isy994
new-feature
new-platform
Quality Scale: No score
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
ISY/IoX Variables have been moved from
sensor
entities tonumber
entities; the existingsensor
entities are deprecated and will be removed in a future release. Theisy994.set_variable
service has been deprecated in favor of using thenumber
entities to directly set the variable values. Please update any dashboards and automations that may be using these entities or service.Proposed change
Add the
number
platform to ISY994 and move ISY/IoX Variables fromsensor
with a custom service to the new platform.There is an existing Config Option for choosing which Variables are added to Home Assistant. This is now used to determine which entities are enabled by default, but all Variables can now be imported.
For each Variable in the ISY/IoX, 2 entities are created; one for the current value and one for the initial value. The initial value entities are always disabled by default.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: