Plugwise: add support for 3-phase DSMR's #85421
Conversation
home-assistant
bot
added
cla-signed
dependency
has-tests
integration: plugwise
new-feature
labels
|
Hey there @CoMPaTech, @brefra, @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| SensorEntityDescription( | ||
| key="voltage_phase_one", | ||
| name="Voltage phase one", | ||
| device_class=SensorDeviceClass.VOLTAGE, | ||
| native_unit_of_measurement=UnitOfElectricPotential.VOLT, | ||
| state_class=SensorStateClass.MEASUREMENT, | ||
| ), | ||
| SensorEntityDescription( | ||
| key="voltage_phase_two", | ||
| name="Voltage phase two", | ||
| device_class=SensorDeviceClass.VOLTAGE, | ||
| native_unit_of_measurement=UnitOfElectricPotential.VOLT, | ||
| state_class=SensorStateClass.MEASUREMENT, | ||
| ), | ||
| SensorEntityDescription( | ||
| key="voltage_phase_three", | ||
| name="Voltage phase three", | ||
| device_class=SensorDeviceClass.VOLTAGE, | ||
| native_unit_of_measurement=UnitOfElectricPotential.VOLT, | ||
| state_class=SensorStateClass.MEASUREMENT, | ||
| ), |
There was a problem hiding this comment.
Please address this comment in a new PR.
Voltage sensors should be disabled by default, as per developer documentation:
Ref: https://developers.home-assistant.io/docs/core/entity
Voltage is really uncommon to be generally used.
/CC: @elupus
There was a problem hiding this comment.
This is not battery voltage?
Ps. But I can sort of accept that it should be disabled by default since its rather not much use to know mains voltage.
There was a problem hiding this comment.
Frenck is right, this is line voltage of the invididual line phase leads
There was a problem hiding this comment.
i.e. The P1 is used for DSMR monitoring of gas / electricity (not to confuse with the climate parts)
There was a problem hiding this comment.
This is not battery voltage?
Ps. But I can sort of accept that it should be disabled by default since its rather not much use to know mains voltage.
Yeah, the example is a battery, but the general consensus in that example applies. Voltage is really rare to use, but it fluctuates a lot (thus causing lots of data recording, mostly unneeded).
* Bump plugwise to v0.27.0 * Add p1-3phase test-fixture * Add the new 3ph P1 DSMR sensors * Add p1 3ph test-case
Plugwise Smile P1: add support for 3-phase DSMR's, via plugwise v0.27.0
https://github.com/plugwise/python-plugwise/releases/tag/v0.27.0
plugwise/python-plugwise@v0.25.14...v0.27.0
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: