Add Thread integration #85002
Merged
Add Thread integration #85002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
has-tests
new-integration
integration: thread
labels
emontnemery
force-pushed
the
thread_mvp
branch
from
022ab6b to
b9b068b
Compare
balloob
reviewed
Jan 9, 2023
agners
reviewed
Jan 12, 2023
balloob
reviewed
Jan 12, 2023
balloob
reviewed
Jan 12, 2023
balloob
reviewed
Jan 12, 2023
balloob
reviewed
Jan 12, 2023
| async def async_get_thread_state(hass: HomeAssistant) -> ThreadState: | ||
| """Get current Thread state.""" | ||
|
|
||
| response = await async_get_clientsession(hass).get( |
There was a problem hiding this comment.
Can we make a helper class for the API that has a request wrapper to handle the raise for status?
https://github.com/esphome/dashboard-api/blob/main/esphome_dashboard_api/__init__.py#L42-L54
There was a problem hiding this comment.
And I think that we should extract that API class into a new repository under home-assistant-libs.
balloob
reviewed
Jan 12, 2023
balloob
reviewed
Jan 12, 2023
balloob
reviewed
Jan 16, 2023
| return self.async_abort(reason="single_instance_allowed") | ||
|
|
||
| config = discovery_info.config | ||
| return self.async_create_entry( |
There was a problem hiding this comment.
for now ok if we only set it up as part of multi pan. In future we should have a confirm step
balloob
approved these changes
Jan 16, 2023
frenck
added
the
noteworthy
rlippmann
pushed a commit
to rlippmann/core
that referenced
this pull request
Jan 18, 2023
* Add Thread integration * Add get/set operational dataset as TLVS * Add create operational dataset * Add set thread state * Adjust after rebase * Improve HTTP status handling * Improve test coverage * Change domains from thread to otbr * Setup otbr from a config entry * Add files * Store URL in config entry data * Make sure manifest is not sorted * Remove useless async * Call the JSON parser more * Don't raise exceptions without messages * Remove stuff which will be needed in the future * Remove more future stuff * Use API library * Bump library to 1.0.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add Thread integration which interfaces with the Open Thread Border Router's REST API
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: