-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renovate Airvisual tests #84892
Renovate Airvisual tests #84892
Conversation
valid_keys.add(user_input[CONF_API_KEY]) | ||
if errors: | ||
return self.async_show_form( | ||
step_id=error_step, data_schema=error_schema, errors=errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like we can and are moving directly to the form of another step. That's not good. The form is private to its step method. We should only move to another step by awaiting that step method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MartinHjelmare Absolutely. Renovating the config flow itself will make this PR bigger; would you be open to approving this one's focus on tests, then I can follow up with an additional PR to fix ^^^?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks!
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Proposed change
The AirVisual test suite needed a little love. This PR cleans it up:
data_entry_flow.FlowResultType.CREATE_ENTRY
ordata_entry_flow.FlowResultType.ABORT
.test_init.py
.In so doing, I discovered a bug where the config flow would "see" an API key even if that API key failed.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: